On Wed, 2006-01-04 at 10:43 +1100, Benjamin Herrenschmidt wrote:
> Does that restore things like selected rate, essid, etc... ? We do
> lose those with ifdown/ifup ...
I haven't had to select a rate. I do have to manually set the essid when
I bring the device up because otherwise it refuses to consider my AP --
and that configuration does still seem to be present after resume.
Hm, thanks for the reminder...
We shouldn't discard networks with encryption in
network_matches_request() -- they might be all we have, and we might
have a key which matches, or something waiting to provide it (or
authenticate in other ways).
There's perhaps a justification for preferring a network without
encryption in the as-yet-unimplemented code which picks the 'best'
network from the list of available networks in
ieee80211softmac_assoc_work(), but we shouldn't just exclude it from
that list completely.
--- linux-2.6.15/net/ieee80211/softmac/ieee80211softmac_assoc.c~
2006-01-04 08:39:52.000000000 +0000
+++ linux-2.6.15/net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-01-04
08:46:02.000000000 +0000
@@ -127,9 +127,7 @@ network_matches_request(struct ieee80211
if (!we_support_all_basic_rates(mac, net->rates_ex, net->rates_ex_len))
return 0;
- /* if 'ANY' network requested, take any that doesn't have privacy
enabled */
- if (mac->associnfo.req_essid.len == 0
- && !(net->capability & WLAN_CAPABILITY_PRIVACY))
+ if (mac->associnfo.req_essid.len == 0)
return 1;
if (net->ssid_len != mac->associnfo.req_essid.len)
return 0;
@@ -178,6 +176,7 @@ ieee80211softmac_assoc_work(void *d)
*
* We also should take into account the rateset
* here to find the best BSSID to try.
+ * And also encryption.
*/
if (network_matches_request(mac, net)) {
if (!best) {
--
dwmw2
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
http://lists.berlios.de/mailman/listinfo/bcm43xx-dev
