On Wednesday 10 May 2006 22:57, you wrote:
> On Sun, May 07, 2006 at 03:16:08PM +0200, Michael Buesch wrote:
> > On Sunday 07 May 2006 15:03, you wrote:
> > > > +       list_for_each_entry(rng, &rng_list, list) {
> > > > +               if (strncmp(rng->name, buf, len) == 0) {
> > > 
> > > This will match if the passed string is just a prefix of rng->name.
> > > Apparently sysfs guarantees that the buffer passed to ->store will be
> > > NUL-terminated, so this should be just a strcmp().
> > 
> > I am not sure if it is guaranteed NUL terminated. Greg?
> > But I will look into this.
> 
> Yes it will be.

Ok, very nice.
I will resend the patches as soon as I have some time.
I also splitted up the x86 drivers. Looks very good and clean now. ;)

-- 
Greetings Michael.
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
http://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to