Michael Buesch wrote:
> On Wednesday 24 January 2007 23:59, Jory A. Pratt wrote:
>> Michael Buesch wrote:
>>> On Wednesday 24 January 2007 20:08, Larry Finger wrote:
>>>
>>>> Michael Buesch wrote:
>>>>
>>>>> On Wednesday 24 January 2007 19:39, Larry Finger wrote:
>>>>>
>>>>>> switch (led_index) {
>>>>>> case 0:
>>>>>> led->behaviour = BCM43xx_LED_ACTIVITY;
>>>>>> + led->activelow = 1;
>>>>>>
>>>>> Why activelow?
>>>>>
>>>> It makes the light be on when there is no activity and blink off when
>>>> there is. With that behavior,
>>>> it is a lot easier to see that the switch is on.
>>>>
>>> Ah, ok.
>>> It's debatable if that behaviour is desireable.
>>> I don't like it, but if people want to have it, we can implement it.
>>>
>>>
>> I do not think this is what people want. If the radio is off the light
>> should just be off, when radio is on turn the light on, is a much more
>> desirable.
>
> Well, we are talking about the "activity" LED, not about the "radio on"
> LED. There are many cards out there (including ethernet cards) which
> always have the LED on and flash it for activity. So it's not _that_
> wrong to do it.
> Personally, I think it's more intuitive to have a LED off, when there
> is no activity, but hey... .
> It could also save a little bit of power on notebooks, if we leave
> it activehigh. But on the other side, if someone is concerned about
> the LEDs drawing too much current, he can as well completely disable
> the LEDs with the module parameter.
If the LED that shows the radio switch state were different than the one used
to show activity, then
I would agree with you; however, it is the same one. If we want the light on
when the switch is on
(and the interface is up) and I think we do, then we need the behavior I coded.
If there were a way to determine if the hardware-enabled bit were determined by
a switch, then we
could make activelow conditional, but that is not the case. It doesn't matter
to me as my switch is
a slide, and I always know if the radio is enabled; however, a lot of them are
momentary switches
that seem to toggle a bit in the hardware. Those people need positive feedback
that the radio is
enabled. Without the activelow, their light would be on if the radio were off,
and vice versa. That
would be too much confusion!
Larry
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
