Joe, Joseph Jezak wrote: > David Woodhouse wrote: >> On Fri, 2007-03-02 at 11:30 -0600, Larry Finger wrote: >>> There was an error in the B5PHY init specifications. >> This patch doesn't fix the machine check in bcm43xx_phy_initb5 which >> Pavel Roskin and I reported a couple of weeks ago. To get rid of that >> crash, I still have to revert an earlier 'spec update' patch >> (740ac4fb08866d702be90f167665d03759bd27d0). >> > > Yeah, the issue is that the Rev1 cards have to be init'd with g mode > off. I'm not sure anyone has picked up this fix yet. The relevant > spec fix is here: http://bcm-v4.sipsolutions.net/802.11/PHY/calinit
I think the bug may be even deeper. In bcm43xx_phy_connect, the G Mode Enable bit of TM State Low is only written for phy->rev >= 5. I have not found any other place where that bit is set. From what I read in the specs, that bit should exist and be set for all G PHY's. Is that correct? I think I'm beginning to understand the confusion between phy->connected in the code and gmode in the specs. Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
