On Wednesday 28 March 2007 19:28, Will Dyson wrote: > On 3/24/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > I _still_ think that this should be fixed in the arch DMA code > > and _not_ in every single driver on earth. But I discussed this in > > the past. > > That would be nice. What would that look like to you? A GFP flag that > gets memory within the dma_mask?
The dma_mask must be honored for _all_ DMA mapping actions without exceptions. That's what that mask is for. > > Ehm, no. This would always allocate in the DMA zone, even if there > > is no requirement to do so (on i386 for example). > > Oops. That'll teach me to hurry a patch before I go away. Less than 1G > low memory is the norm. > > I'll fix the word-wrap and make sure to run indent as well. Ok, thanks. I'll apply a patch to workaround the issue in the driver to my tree, but only while explicitely stating that I'd like to have a fix in the arch code for this. Unfortunately I can't easily do it myself, as I don't have a machine with this problem here. And yes, I know that it's probably hard to fix. ;) But it should be possible to always honor the dma_mask. It might require some rewrite of the lowlevel DMA code and probably some IOMMU stuff and so on, dunno. -- Greetings Michael. _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
