On Saturday 23 June 2007 04:26:42 Larry Finger wrote: > Michael Buesch wrote: > > On Friday 22 June 2007 21:43:43 Larry Finger wrote: > >> This patch fixes some differences between the specs in > >> http://bcm-v4.sipsolutions.net/802.11/PHY/G/workarounds/WRSSI_offset and > >> the bcm43xx-mac80211 code. > >> > >> Signed-off-by: Larry Finger <[EMAIL PROTECTED]> > >> --- > >> > >> Index: wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c > >> =================================================================== > >> --- wireless-mb.orig/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c > >> +++ wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c > >> @@ -961,12 +961,8 @@ static void bcm43xx_phy_setupg(struct bc > >> if (phy->rev == 1) { > >> for (i = 0; i < BCM43xx_TAB_RETARD_SIZE; i++) > >> bcm43xx_ofdmtab_write32(dev, 0x2400, i, > >> bcm43xx_tab_retard[i]); > >> - for (i = 0; i < 4; i++) { > >> - bcm43xx_ofdmtab_write16(dev, 0x5404, i, 0x0020); > >> - bcm43xx_ofdmtab_write16(dev, 0x5408, i, 0x0020); > >> - bcm43xx_ofdmtab_write16(dev, 0x540C, i, 0x0020); > >> - bcm43xx_ofdmtab_write16(dev, 0x5410, i, 0x0020); > >> - } > >> + for (i = 4; i < 20; i++) > >> + bcm43xx_ofdmtab_write16(dev, 0x5400, i, 0x0020); > >> bcm43xx_phy_agcsetup(dev); > >> > >> if ((bus->boardinfo.vendor == SSB_BOARDVENDOR_BCM) && > >> @@ -977,7 +973,7 @@ static void bcm43xx_phy_setupg(struct bc > >> bcm43xx_ofdmtab_write16(dev, 0x5001, 0, 0x0002); > >> bcm43xx_ofdmtab_write16(dev, 0x5002, 0, 0x0001); > >> } else { > >> - for (i = 0; i <= 0x2F; i++) > >> + for (i = 0; i < 0x20; i++) > >> bcm43xx_ofdmtab_write16(dev, 0x1000, i, 0x0820); > >> bcm43xx_phy_agcsetup(dev); > >> bcm43xx_phy_read(dev, 0x0400); /* dummy read */ > >> > >> > > > > Stefano's big patch is supposed to fix this. Though, it doesn't work, yet. > > I'll give your patch a try and apply it, if it works fine. Did you test it? > > On which devices? > > It has been tested on the BCM4311, where it didn't make much difference. I'll > be testing it next on > a phy->rev == 1 BCM4306.
I applied this, but please still test it on your rev1 4306. -- Greetings Michael. _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
