David Woodhouse wrote: > On Mon, 2007-07-09 at 22:59 +0000, Linux Kernel Mailing List wrote: >> Gitweb: >> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=77548f58070894cf5970a110981e511ffe793369 >> Commit: 77548f58070894cf5970a110981e511ffe793369 >> Parent: aaf83d4fc4a596929306c894d341e17fbdfba758 >> Author: Larry Finger <[EMAIL PROTECTED]> >> AuthorDate: Sat May 26 22:21:29 2007 -0500 >> Committer: Jeff Garzik <[EMAIL PROTECTED]> >> CommitDate: Sun Jul 8 22:16:37 2007 -0400 >> >> [PATCH] bcm43xx: Fix deviation from specifications in >> set_baseband_attenuation >> >> A disagreement between the specifications and the bcm43xx code has just >> been discovered and is hereby fixed. >> >> Signed-off-by: Larry Finger <[EMAIL PROTECTED]> >> Signed-off-by: John W. Linville <[EMAIL PROTECTED]> >> --- >> drivers/net/wireless/bcm43xx/bcm43xx_phy.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_phy.c >> b/drivers/net/wireless/bcm43xx/bcm43xx_phy.c >> index b37f1e3..d779199 100644 >> --- a/drivers/net/wireless/bcm43xx/bcm43xx_phy.c >> +++ b/drivers/net/wireless/bcm43xx/bcm43xx_phy.c >> @@ -1638,7 +1638,7 @@ void bcm43xx_phy_set_baseband_attenuation(struct >> bcm43xx_private *bcm, >> return; >> } >> >> - if (phy->analog > 1) { >> + if (phy->analog == 1) { >> value = bcm43xx_phy_read(bcm, 0x0060) & ~0x003C; >> value |= (baseband_attenuation << 2) & 0x003C; >> } else { >> - > > This broke my shinybook. I seem to get absolutely _no_ outgoing packets, > although I can receive OK. > > bcm43xx: Chip ID 0x4306, rev 0x2 > bcm43xx: Number of cores: 6 > bcm43xx: Core 0: ID 0x800, rev 0x2, vendor 0x4243 > bcm43xx: Core 1: ID 0x812, rev 0x4, vendor 0x4243 > bcm43xx: Core 2: ID 0x80d, rev 0x1, vendor 0x4243 > bcm43xx: Core 3: ID 0x807, rev 0x1, vendor 0x4243 > bcm43xx: Core 4: ID 0x804, rev 0x7, vendor 0x4243 > bcm43xx: Core 5: ID 0x812, rev 0x4, vendor 0x4243 > > bcm43xx: Detected PHY: Analog: 1, Type 2, Revision 1 > bcm43xx: Detected Radio: ID: 2205017f (Manuf: 17f Ver: 2050 Rev: 2) > > bcm43xx: Microcode rev 0x122, pl 0x99 (2005-01-22 22:40:08)
David, Thanks for your report. This section obviously needs additional investigation. John, Please revert this patch. Should I push the reversion upstream, or will you? Thanks, Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
