On Friday 24 August 2007 16:51:07 Larry Finger wrote:
> From: Johannes Berg <[EMAIL PROTECTED]>
>
> This patch makes b43legacy include the FCS at the end of
> received frames, useful for monitoring.
Did you test this with WEP, WPA/AES and without encryption?
There was a very good reason why I chose to strip and IV, ICV
and FCS of the end of frames. And it was crypto related.
Maybe that limitation was removed, so this patch might actually
be OK. But please test it on all crypto configs.
> Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
> Signed-off-by: Larry Finger <[EMAIL PROTECTED]>
> ---
>
> drivers/net/wireless/b43legacy/main.c | 3 ++-
> drivers/net/wireless/b43legacy/xmit.c | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: wireless-dev/drivers/net/wireless/b43legacy/main.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/b43legacy/main.c
> +++ wireless-dev/drivers/net/wireless/b43legacy/main.c
> @@ -3623,7 +3623,8 @@ static int b43legacy_wireless_init(struc
>
> /* fill hw info */
> hw->flags = IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE |
> - IEEE80211_HW_WEP_INCLUDE_IV;
> + IEEE80211_HW_WEP_INCLUDE_IV |
> + IEEE80211_HW_RX_INCLUDES_FCS;
> hw->max_signal = 100;
> hw->max_rssi = -110;
> hw->max_noise = -110;
> Index: wireless-dev/drivers/net/wireless/b43legacy/xmit.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/b43legacy/xmit.c
> +++ wireless-dev/drivers/net/wireless/b43legacy/xmit.c
> @@ -465,7 +465,6 @@ void b43legacy_rx(struct b43legacy_wldev
> }
> wlhdr = (struct ieee80211_hdr *)(skb->data);
> fctl = le16_to_cpu(wlhdr->frame_control);
> - skb_trim(skb, skb->len - FCS_LEN);
>
> if ((macstat & B43legacy_RX_MAC_DEC) &&
> !(macstat & B43legacy_RX_MAC_DECERR)) {
--
Greetings Michael.
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
