Hello! On Sat, 2007-09-08 at 15:08 +0800, Sepherosa Ziehau wrote:
> Following patch make b43-fwcutter work on DragonFlyBSD: > http://leaf.dragonflybsd.org/~sephe/fwcutter.diff > > Please review it. If you folks think it is OK, please commit it to > your svn repos. > It was reviewed by johill and mb on #bcm-specs I suggest that you remove all references to DragonFlyBSD and use some symbol that is defined on all BSD systems. This way, the program will compile and work with no changes on all BSD systems as long as the headers are compatible. And if there are any incompatibilities, they would likely be minor and fixable without adding too many ifdefs. The patch as it is just encourages adding more preprocessor conditionals if the program is ported to more OSes. Also, I suggest that you reconsider calling the firmware directories "v3" and "v4". Such names are too generic and don't provide information about the hardware, unlike "b43" and "b43legacy". It would be easier if b43-fwcutter just worked the same way on any OS. You may prefer to do renaming in a wrapper that installs the firmware. I would put definitions for bswap_16 and bswap_32 immediately below "#include <sys/endian.h>", but it's a mater of taste. Also, I would use definitions with arguments, as they are more robust and would indicate use with a wrong number of arguments. -- Regards, Pavel Roskin _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
