Michael Buesch wrote: > On Friday 25 April 2008 06:55:54 Larry Finger wrote: >> Michael, >> >> I have discovered that both sprom_extract_r123() in the ssb driver, >> and ssb-sprom use a two-byte quantity to extract the board revision. >> In the specifications detailed in >> http://bcm-v4.sipsolutions.net/SPROM, a single-byte is used for this >> parameter. >> >> It is unlikely that this causes any serious difficulties; however, at >> least one fixup depends on the board revision, and I wanted to be >> certain that you were aware of the situation. > > I'm not sure what you're talking about. > > #define SSB_SPROM1_BINF_BREV 0x00FF /* Board Revision */ > SPEX(board_rev, SSB_SPROM1_BINF, SSB_SPROM1_BINF_BREV, 0); >
Yes - 2 bytes in the code above, but the spec says bits 0-7! Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
