On Thu, 2009-01-15 at 09:48 +0800, YanBo wrote:
> > I think you should give these different names, rather than sub-indexing
> > in that array.
> >
>
> Yes, they has been assigned difference names. like below
> +enum b43_nphy_txgain_type {
> + REV_LE2 = 0, /* rev <= 2 */
> + REV_GE3_2G, /* rev >= 3 (2.4 GHz) */
> + REV_E3_5G, /* rev 3 (5 GHz) */
> + REV_GE4_5G, /* rev >= 4 (5 GHz) */
> +};
> But above code was split into patch 4/7 by my mistake.Yes, but I think you should give them names, not just named array indexes. johannes
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
