Hi Michael,
what do you mean with "non-mangled" version?
I also noticed that most of the plcp rate errors seem due to an
incorrect padding value passed by the firmware. The plcp looks correct
but improperly shifted. Any ideas about that?
cheers
Lorenzo.
On Mar 22, 2009, at 5:34 PM, Michael Buesch wrote:
> On Sunday 22 March 2009 17:32:35 Lorenzo Nava wrote:
>> This patch fixes the return type of b43_plcp_get_bitrate_idx_ofdm. If
>> the plcp contains an error, the function return value is 255 instead
>> of -1, and the packet was not dropped. This causes a warning in
>> __ieee80211_rx function because rate idx is out of range.
>
> Hm, nice catch. This should be causing the RX path warnings.
>
> Can you send a non-mangled version?
>
>>
>>
>> Index: wireless-testing/drivers/net/wireless/b43/xmit.c
>> ===================================================================
>> --- wireless-testing.orig/drivers/net/wireless/b43/xmit.c 2009-03-22
>> 17:25:19.000000000 +0100
>> +++ wireless-testing/drivers/net/wireless/b43/xmit.c 2009-03-22
>> 17:25:40.000000000 +0100
>> @@ -50,7 +50,7 @@
>> }
>>
>> /* Extract the bitrate index out of an OFDM PLCP header. */
>> -static u8 b43_plcp_get_bitrate_idx_ofdm(struct b43_plcp_hdr6 *plcp,
>> bool aphy)
>> +static int b43_plcp_get_bitrate_idx_ofdm(struct b43_plcp_hdr6 *plcp,
>> bool aphy)
>> {
>> int base = aphy ? 0 : 4;
>>
>>
>
>
>
> --
> Greetings, Michael.
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
