On Mar 28, 2009, at 12:53 AM, Michael Buesch wrote: > On Saturday 28 March 2009 00:49:12 Francesco Gringoli wrote: >> On Mar 27, 2009, at 10:51 PM, Michael Buesch wrote: >> >>> This patch adds poisoning and sanity checking to the RX DMA buffers. >>> This is used for protection against buggy hardware/firmware that >>> raises >>> RX interrupts without doing an actual DMA transfer. >>> >>> This mechanism protects against rare "bad packets" (due to >>> uninitialized skb data) >>> and rare kernel crashes due to uninitialized RX headers. >>> >>> >>> Francesco, please stresstest this. >> Hi Michael, >> >> thank you for the patch, I will test it ASAP. Before testing, >> however, >> I would like to have a feedback about sanity checking directly the >> rxhdr. Two reasons: 1) also with the patch I sent you yesterday, I >> continued to observe kernel freezing with FCSFAIL set 2) I fear that >> when dma_rx is triggered with such dma events, also the content of >> rxhdr can be broken. In particular if the rxhdr->len reports an >> incredible long frame, dma_rx could begin recycling too many skbs. I >> was reported (by Bo) that when this happens, kernel would likely >> freeze. > > This should be fixed by this patch as well. Yes you are right :-) sorry. Testing tomorrow, pc is crashed in my office now. I'll let you know.
Cheers, -FG _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
