This patch fixes mac extraction from rev 8 sproms.

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 593fc61..064930d 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -480,9 +481,12 @@ static void sprom_extract_r8(struct ssb_sprom *out, const 
u16 *in)

        /* extract the MAC address */
        for (i = 0; i < 3; i++) {
-               v = in[SPOFF(SSB_SPROM1_IL0MAC) + i];
+               v = in[SPOFF(SSB_SPROM8_IL0MAC) + i];
                *(((__be16 *)out->il0mac) + i) = cpu_to_be16(v);
        }


# ifconfig wlan0
wlan0     Link encap:Ethernet  HWaddr 00:1A:73:E4:F6:89
          BROADCAST MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 b)  TX bytes:0 (0.0 b)

# ifconfig wlan0 up
SIOCSIFFLAGS: Operation not supported

But now in log:
[ 2035.736059] b43 ssb0:0: firmware: requesting b43/ucode13.fw
[ 2036.088416] b43-phy2 ERROR: The driver does not know which firmware
(initvals) is required for your device (wl-core rev 15)

So now I probably need the patch just posted by Gábor.


Mark


Mark Huijgen wrote:
> Mark Huijgen wrote:
>   
>> Gábor Stefanik wrote:
>>   
>>     
>>>> ifconfig wlan0
>>>> wlan0     Link encap:Ethernet  HWaddr FF:FF:FF:FF:FF:FF
>>>>          BROADCAST MULTICAST  MTU:1500  Metric:1
>>>>          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
>>>>          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
>>>>          collisions:0 txqueuelen:1000
>>>>          RX bytes:0 (0.0 b)  TX bytes:0 (0.0 b)
>>>>
>>>> ifconfig wlan0 up
>>>> SIOCSIFFLAGS: Cannot assign requested address
>>>>     
>>>>       
>>>>         
>>> Uhh, that doesn't look good...
>>>   
>>>     
>>>       
>> I've investigated with some SSB debugging:
>> [ 4895.592113] ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x16, vendor
>> 0x4243)
>> [ 4895.592125] ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0F,
>> vendor 0x4243)
>> [ 4895.592135] ssb: Core 2 found: PCMCIA (cc 0x80D, rev 0x0A, vendor 0x4243)
>> [ 4895.592145] ssb: Core 3 found: PCI-E (cc 0x820, rev 0x09, vendor 0x4243)
>> [ 4895.612051] ssb: Found rev 1 PMU (capabilities 0x02A62F01)
>> [ 4895.620727] ssb: SPROM revision 8 detected.
>> [ 4895.620732] ssb: MAC ff:ff:ff:ff:ff:ff
>> [ 4895.642495] ssb: Sonics Silicon Backplane found on PCI device
>> 0000:10:00.0
>>
>> I added the ssb: MAC line, sprom extraction seems incorrect for this
>> device (is ssb up to date enough in wireless-testing for this device?).
>>   
>>     
> Actual mac determined with broadcoms driver:  00:1A:73:E4:F6:89
> sprom contents:
> 012800007D133C107800BE6D0000C42B642A6429642CE73CFF467F47000C4078A000FFFF0000FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF1543008002000000301F001800000000FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF72530712010A0600000000001A00E47389F645440100FF83FFFFFFFF030002FFFFFFFFFF0F00FFFF6C00FFFFFAFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF4A3E571A8AF991FEFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF0800FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF080E
>
> The mac is stored in the string as 1A00E47389F6.
>
>
> Mark
>
>   

_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to