W dniu 8 stycznia 2010 11:17 użytkownik Michael Buesch <m...@bu3sch.de> napisał: > On Friday 08 January 2010 09:30:27 Rafał Miłecki wrote: >> I need to implement >> http://bcm-v4.sipsolutions.net/802.11/PHY/ClkFgc >> >> Where I can put my >> void b43_phy_clock_fgc(struct b43_wldev *dev, bool clock) { ... } >> ? Is end of phy_common.c file OK for this? > > yes. Note that the 0x20000 bit has defines in ssb_regs.h. So you should use > them. > Also use ssb_read/write to access that register. It's essentially the same > as b43_read/write, but this way it's obvious to humans that we are accessing > a backplane register. > Also maybe don't call the parameter "clock" but "force". Would make more > sense to me...
Thanks Michael. I use CONSTANTS wherever I can and I did in my implementation. Of course I used ssb_* as well :) And even after posting patch I renamed "clock" to "force" :D -- Rafał _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
