On Thursday 14 January 2010 13:21:27 Rafał Miłecki wrote: > > Signed-off-by: Rafał Miłecki <[email protected]> > --- > drivers/net/wireless/b43/phy_common.c | 14 ++++++++++++++ > drivers/net/wireless/b43/phy_common.h | 1 + > drivers/net/wireless/b43/phy_lp.c | 17 ++--------------- > 3 files changed, 17 insertions(+), 15 deletions(-) > > diff --git a/drivers/net/wireless/b43/phy_common.c > b/drivers/net/wireless/b43/phy_common.c > index 75b26e1..1389ab2 100644 > --- a/drivers/net/wireless/b43/phy_common.c > +++ b/drivers/net/wireless/b43/phy_common.c > @@ -421,3 +421,17 @@ void b43_phyop_switch_analog_generic(struct b43_wldev > *dev, bool on) > { > b43_write16(dev, B43_MMIO_PHY0, on ? 0 : 0xF4); > } > + > +/* Find the position of the most significant bit */ > +u8 phy_nbits(s32 val) > +{ > + u32 tmp = abs(val); > + u8 nbits = 0; > + > + while (tmp != 0) { > + nbits++; > + tmp >>= 1; > + } > + > + return nbits; > +}
We already have fls() in bitops.h I think the following call would be equivalent: x = fls(abs(val)); So we don't need our own implementation in phy_common.c. Just use the standard funcs. -- Greetings, Michael. _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
