On Monday 22 February 2010 15:54:33 W. Trevor King wrote:
> On Mon, Feb 22, 2010 at 02:10:38PM +0100, Gianluca Montecchi wrote:
> > On Mon, Feb 22, 2010 at 06:47:54AM -0500, W. Trevor King wrote:
> > > On Mon, Feb 22, 2010 at 11:55:02AM +0100, Gianluca Montecchi wrote:
> > > > > On Fri, Feb 12, 2010 at 12:09:23AM +0100, Gianluca Montecchi wrote:
> > > > > > I pushed to my tree a solution to use shorter file name in the be
> > > > > > html command output (bug-id bea/01e)
> > > > > >
> > > > > > It begin to try with a 3 chars file name, if this fail, it try up
> > > > > > to 8 chars, if it is not possible to create a short file name up
> > > > > > of 8 chars, the full bug uuid is used (like now).
> > > > >
> > > > > I've looked this over, and here are my thoughts:
> > > > > * If you want short bug names, won't you want short comment names
> > > > > too?
> > > >
> > > > In my opinion no. The idea is to have short http address, and with
> > > > be html you access the bug id not the comment.
> > >
> > > You do access comment IDs:
> > > html_export/bugs/01e#2f9
> > > html_export/bugs/12c#469
> >
> > For now you cannot.
>
> Yes you can. In your tree:
>
> class HTMLGen (object):
> ...
> def _generate_bug_comment_entries(self, bug):
> ...
> if depth == 0:
> comment_entries.append('<div class="comment root">')
> else:
> comment_entries.append(
> '<div class="comment" id="%s">' % comment.uuid)
> ...
Wait. This div is only usefull to generate a nice (?) looking tree to indent
the comments. Perhaps I don't explain myself: for "access a comment" I intend
to have a direct link to the comment somwehere in the html code.
So you are somewhat right, I access the comment, but only to read the comment
and put it in the html file of the bug. But since the comment it is not a
separated html file, you cannot access directly the comment with the browser.
To have a short comment id can be usefull in two cases that I can see and
agree:
1) we export all the comments to separated html files, and in the html file of
the bug we put only the header of the comment (or just an extract) and load
the comments on demand, this might require some javascript or AJAX, and can be
usefull with long threads.
2) we put in the actual html file of the bug, with all the comments, an anchor
to be able to do something like "http://www.somewhere.org/bugs/123.html#23k";
to access directly the comment.
bye
Gianluca
_______________________________________________
Be-devel mailing list
[email protected]
http://void.printf.net/cgi-bin/mailman/listinfo/be-devel
