On Tue, Jul 06, 2010 at 06:47:46PM -0400, Chris Ball wrote: > Hi Gian, > > > I just created a new merge request for BE > > > > The patch just add the bug summary to the output of the "be > > depend" command. > > (It'd be good to send a copy of the patch itself for review alongside > small requests like this one.) > > Review comments: > > * There's another place where we print the "blocked by:" string in the > same source file, and you haven't modified that one. (Line 156.)
That is where the parameter --tree-depth is used. I see, but it seems to work well anyway grys:~/Devel/gians-be> ./be depend -t 3 bea/773 bea/773 blocked by: bea/275:fm: Fix Unicode handling. grys:~/Devel/gians-be> > * You've changed the indentation of one of the modified lines, > removing an indent. I'd understand if this enabled the code > to stay within 80 chars, but it doesn't. (Line 188.) Since the line 187 finish with the "\" charater, it is not really important the identation, but I agree. Fixed. > * You haven't changed the text for "blocks:", only "blocked by:". > (Line 191.) Fixed. I updated the merge request and I attached the (now two) patch. bye Gianluca
>From 9f3e40c0d40f174280e69ac28e19fb8bdb273922 Mon Sep 17 00:00:00 2001 From: Gianluca <[email protected]> Date: Wed, 7 Jul 2010 00:24:20 +0200 Subject: [PATCH 1/2] Added the bug summary to the output of the 'be depend' command --- libbe/command/depend.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libbe/command/depend.py b/libbe/command/depend.py index 92140eb..5898fc9 100644 --- a/libbe/command/depend.py +++ b/libbe/command/depend.py @@ -181,11 +181,11 @@ class Depend (libbe.command.Command): print >> self.stdout, '%s blocked by:' % bugA.id.user() if params['show-status'] == True: print >> self.stdout, \ - '\n'.join(['%s\t%s' % (_bug.id.user(), _bug.status) + '\n'.join(['%s\t%s\t%s' % (_bug.id.user(), _bug.status, _bug.summary) for _bug in blocked_by]) else: print >> self.stdout, \ - '\n'.join([_bug.id.user() for _bug in blocked_by]) + '\n'.join(['%s\t%s'%(_bug.id.user(), _bug.summary) for _bug in blocked_by]) blocks = get_blocks(bugdir, bugA) if len(blocks) > 0: print >> self.stdout, '%s blocks:' % bugA.id.user() -- 1.7.1
>From 388358a41375afdca0d29583a0851bfb5fe720f8 Mon Sep 17 00:00:00 2001 From: gian <[email protected]> Date: Wed, 7 Jul 2010 09:03:18 +0200 Subject: [PATCH 2/2] Updated the changes following Chris Rewview --- libbe/command/depend.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libbe/command/depend.py b/libbe/command/depend.py index 5898fc9..d0dd3b3 100644 --- a/libbe/command/depend.py +++ b/libbe/command/depend.py @@ -185,17 +185,17 @@ class Depend (libbe.command.Command): for _bug in blocked_by]) else: print >> self.stdout, \ - '\n'.join(['%s\t%s'%(_bug.id.user(), _bug.summary) for _bug in blocked_by]) + '\n'.join(['%s\t%s'%(_bug.id.user(), _bug.summary) for _bug in blocked_by]) blocks = get_blocks(bugdir, bugA) if len(blocks) > 0: print >> self.stdout, '%s blocks:' % bugA.id.user() if params['show-status'] == True: print >> self.stdout, \ - '\n'.join(['%s\t%s' % (_bug.id.user(), _bug.status) + '\n'.join(['%s\t%s\t%s' % (_bug.id.user(), _bug.status, _bug.summary) for _bug in blocks]) else: print >> self.stdout, \ - '\n'.join([_bug.id.user() for _bug in blocks]) + '\n'.join(['%s\t%s'%(_bug.id.user(), _bug.summary) for _bug in blocks]) return 0 def _long_help(self): -- 1.7.1
_______________________________________________ Be-devel mailing list [email protected] http://void.printf.net/cgi-bin/mailman/listinfo/be-devel
