On Tue, Feb 22, 2011, Michael Chaffin wrote something like: > C:\XXX\ZZZ>bzr version > Bazaar (bzr) 2.2.3 > ... > > A quick check of the code for libbe\storage\vcs\bzr.py on line 140 shows : > > ** SNIP ** > if self.version_cmp(2,3,0) < 0: > cmd.cleanup_now() > ** SNIP ** > > But I am running Bzr 2.2.3 ... so version_cmp(...) would return -1 where -1 > < 0 and it will call cmd.cleanup_now( ).
Oops. See below.
> I made a quick change to the following, and re-installed.
>
> ** SNIP **
> if self.version_cmp(2,3,0) >= 0:
> cmd.cleanup_now()
> ** SNIP **
Nope. Earlier versions of bzrlib required explicit calls to
cmd.cleanup_now(), so we want to keep the '<'. However, 2.3.0 is not
right. The comparison should be against 2.2.0:
bzr.dev $ ./bzr log -p -n 0 -r 5146 | grep -1 deprec
+
+ @deprecated_method(deprecated_in((2, 2, 0)))
def run_direct(self, *args, **kwargs):
--
+
+ @deprecated_method(deprecated_in((2, 2, 0)))
def run_direct(self, *args, **kwargs):
I've pushed a fixed comparison in my tree. However, your change did
disable the call, which is what the fixed comparison will do, and you
still got an error:
> Which gave me the following traceback error :
>
> ** SNIP **
> C:\XXX\ZZZ>be init
> Traceback (most recent call last):
> ...
> bzrlib.errors.LockContention: Could not acquire lock
> "C:/XXX/ZZZ/.bzr/checkout/dirstate": (32, 'CreateFileW', 'The process cannot
> access the file because it is being used by another process.')
> ** SNIP **
So something funny is going on...
This is the type of error you get when cleanup_now is not run, and a
subsequent bzr command tries to get resources held by a previous
command.
Perhaps it was because you only adjusted one of the new version
comparisons, since there are several cleanup_now calls.
> Thank you for the help ... as I have said I can poke things a little
> bit from my end as well. I guess the short easy answer is ... there
> is no magic switch I am missing or package to install? This might be
> a bug between Bugs Everywhere and bzlib for now?
That's right.
I just installed Bazaar 2.2.3 to test my current HEAD and everything
seems to work... Could you run `git pull`, re-install, and try again?
--
This email may be signed or encrypted with GPG (http://www.gnupg.org).
The GPG signature (if present) will be attached as 'signature.asc'.
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
My public key is at http://www.physics.drexel.edu/~wking/pubkey.txt
pgpjGHuhm2VOu.pgp
Description: PGP signature
_______________________________________________ Be-devel mailing list [email protected] http://void.printf.net/cgi-bin/mailman/listinfo/be-devel
