On Fri, Apr 15, 2011 at 12:03:59AM +0200, Julien Muchembled wrote:
> I guess "USERNAME" is for Windows and could contain capitals.
> Now, get_fallback_email could be changed to:
>
> def get_fallback_email():
> """Return an email address extracted from environmental variables.
> """
> return os.getenv('EMAIL') or "%s@%s" % (get_fallback_username().lower(),
> gethostname())Oops, forgot that part, thanks. Patch pushed to my repo. I dropped lower(). I don't think messing with the local-part of email addresses is a good idea, although Wikipedia claims that most mail servers are case-insensitive [1]. > > Out of curiosity, was there some sort of issue that inspired this patch? > > Just trying bugs-everywhere outside any repository and saw that it > didn't create tickets with good values in 'Reporter' & 'Creator' > fields. In fact, even inside a Git one, it failed, because I don't > redefine my email & full name in gitconfig. Fair enough. I don't usually bother setting up the comment field in /etc/passwd, so I hadn't expected things to work well without some kind of per-user configuration. Let us know if it's missing anything else ;). [1] http://en.wikipedia.org/wiki/Email_address#Local-part_normalization -- This email may be signed or encrypted with GPG (http://www.gnupg.org). The GPG signature (if present) will be attached as 'signature.asc'. For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy My public key is at http://www.physics.drexel.edu/~wking/pubkey.txt
pgpo3lIUSvNbA.pgp
Description: PGP signature
_______________________________________________ Be-devel mailing list [email protected] http://void.printf.net/cgi-bin/mailman/listinfo/be-devel
