Hi,

On Saturday, September 28, 2013 4:32:13 PM UTC+3, Harry May wrote:
>
> This kernel modul may be useful for kernel module beginners (like myself) 
> to show usage of these kernel functions:
>

May I suggest a few formal things - without going into technical details?

*) try to write it in the Linux kernel programming style

indent -nbad -bap -nbc -bbo -hnl -br -brs -c33 -cd33 -ncdb -ce -ci4 -cli0 
-d0 -di1 -nfc1 -i8 -ip0 -l80 -lp -npcs -nprs -npsl -sai -saf -saw -ncs -nsc 
-sob -nfca -cp33 -ss -ts8 -il1 counter_driver.c

might be a good starting point

run checkpatch.pl  and adjust the kernel code until checkpatch is happy, 
you can find this script under the linux kernel tree

linux/scripts/checkpatch.pl --file counter_driver.c

*) why don't you put this as a little project under a public git repo?

Regards,

Robert

-- 
For more options, visit http://beagleboard.org/discuss
--- 
You received this message because you are subscribed to the Google Groups 
"BeagleBoard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to