----- Original Message ----- > From: "Jan Stourac" <jstou...@redhat.com> > To: "Beaker development" <beaker-devel@lists.fedorahosted.org> > Sent: Thursday, October 29, 2015 1:17:19 PM > Subject: Re: [Beaker-devel] Proposed changes to recipe set ack/nak/comments > > Hi all, > > comment following: > > > > > > > Hmm interesting. We hadn't thought of either of those scenarios. > > > > > > As for the second point, keeping track of what you have reviewed... > > > Gerrit has quite a nice simple system for that, which we could take some > > > inspiration from. Each file in the patch has a little checkbox > > > "Reviewed" which is unticked by default. It's ticked automatically when > > > you first view each file. And you can toggle them on or off explicitly > > > as well, to mark where you are up to in the review. Or you can just > > > ignore them. > > > > > > We could do something similar. The job page could have a checkbox for > > > each recipe. We would record each user's "reviewed" status for each > > > recipe. When you open the recipe page we mark it as reviewed > > > automatically, or you can tick or untick the checkbox explicitly. > > > Something like this: > > > > > > https://fedorapeople.org/~dcallagh/screenshot-new-job-page-reviewed-checkboxes.png > > > > > > Then waiving and commenting would still be a separate operation. The > > > "reviewed" check boxes might be more generally useful even when not > > > waiving results too. > > > > > I like it. The mock up looks good. The only thing that people may want is > > the > > ability to "Check All" > This sounds like there is need for bulk actions. In such case I quite do not > like this mock up. I would rather see those tick boxes in front of each of > the job (row) to be used for possible bulk actions (e.g. "Mark checked", > "Delete", "Cancel" and so on) and use another way to present that particular > job has been reviewed - another column with some icon (I suppose column > should have some title)? Or highlight whole row with some color? Or just > part of it? Whyt? Oh, ok - now I see that given mock up page shows view of recipes in job. I suppose that you can ignore my comment now :) Sorry for confusion here.
Jan _______________________________________________ Beaker-devel mailing list Beaker-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/beaker-devel
