I love CI. CI is good. I'll try enabling Atlassian's pipelines thing, see if it works. In the past I've worked with buildbot. We should indeed have a working build status on a minimal Docker install somewhere.
On Sat, Mar 31, 2018 at 1:46 PM, Jakob Schnitzer <[email protected]> wrote: > I think one thing CI adds is a certain reproducibility. I can remember > having the full Beancount test suite pass exactly once (after I submitted a > PR fixing some broken tests). Having a test suite that doesn't fully pass > (fully passing on just the main developer's computer doesn't count IMHO), > when new to a project this to me sends a message 'this project doesn't care > too much about tests'. From the mailing list and the quality of code and > tests I of course know this to be false - having a frequent CI build could > still help with obtaining (and keeping) a more reproducible test suite (and > make the standard of tests clear to potential contributors). > > With regards to linting, I'm not sure what the standard is (`make lint`) > fails with a staggering list of 'errors'. Again, having a CI build would > more clearly communicate the expected standard with regards to linting. > > On Sat, Mar 31, 2018 at 12:45:12PM -0400, Martin Blais wrote: > >> CI only makes it easier to run the test, it doesn't write the tests. >> Running the tests is easy ("make test" locally) >> >> >> On Sat, Mar 31, 2018 at 5:02 AM, Stefano Zacchiroli <[email protected]> >> wrote: >> >> On Thu, Mar 29, 2018 at 08:30:30PM -0400, Martin Blais wrote: >>> > You speak as if a little bit of untested code is worth anything. It's >>> > not. Let me explain. >>> >>> Oh, no, I agree it's not worth it. And it's great that you, as Beancount >>> maintainer, have high standards for code acceptance that encompass: (1) >>> not breaking existing tests, and (2) having thorough unit tests for the >>> new code being contributed. >>> >>> But it seems to me that that is almost completely unrelated to the >>> choice of hosting platform, isn't it? Aren't you in fact just saying >>> that what you want is continuous integration (CI) integrated with the >>> contribution work-flow for proposed patches? >>> >>> Both GitLab and GitHub have integrated CI offerings, and IME they go a >>> long way in avoiding wasting maintainer time in "complaining" about >>> breaking existing tests. You make the CI run on incoming patches, if >>> existing tests get broken by it, submitters get immediate feedback about >>> it and can iterate by themselves to fix that, without any need of your >>> intervention. And, in fact, you can do the same for missing tests. Just >>> enable the nose (or equivalent) code coverage plugin and make it fail if >>> the coverage is not up to a given standard or threshold, and there too >>> you automatically send the ball back in the camp of code contributors if >>> they don't show up with tests. >>> >>> I don't know if BitBucket has any CI integration, but I'd be surprised >>> if it doesn't. Aside from that aspect, this seem unrelated to the "lower >>> barriers for contribution due to what is well-known out there". (But is >>> an interesting discussion anyway!) >>> >>> Cheers >>> -- >>> Stefano Zacchiroli . [email protected] . upsilon.cc/zack . . o . . . o . o >>> Computer Science Professor . CTO Software Heritage . . . . . o . . . o o >>> Former Debian Project Leader & OSI Board Director . . . o o o . . . o . >>> « the first rule of tautology club is the first rule of tautology club » >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Beancount" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> To post to this group, send email to [email protected]. >>> To view this discussion on the web visit https://groups.google.com/d/ >>> msgid/beancount/20180331090248.GD13350%40upsilon.cc. >>> For more options, visit https://groups.google.com/d/optout. >>> >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Beancount" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> To view this discussion on the web visit https://groups.google.com/d/ms >> gid/beancount/CAK21%2BhPNHd3EUyDN%2B6Wsqx127qXu8bZXM0xiKLepV >> NN8yRRCsQ%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Beancount" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ms > gid/beancount/20180331174637.GA6277%40js-arch. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/CAK21%2BhNccecsG%2BV6vAsAdpnY7rQaU0WqdZ1zT%3D6WQZPCgHWT%3DQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
