On Mon, May 7, 2018 at 4:58 AM, Martin Michlmayr <t...@cyrius.com> wrote:
> * Martin Blais <bl...@furius.ca> [2018-05-06 22:16]: > > However, I first merged in the entire history of his work so that > > it's there for keeps in the repo hsitory, in case it's ever needed > > to reimplement the lexer-based one. Then I rolled back to the > > simpler version, and amended a few things. > > Oh, I see. Ok, I didn't realize there were two versions which > resulted in my confusion why the original patch was so different to > the final patch. > > > > Test case: > > > > > > 2018-03-26 * "Lower case should work now" > > > Expenses:école 10.00 EUR > > > > > > This is expected, should not work. The idea is to preserve the > > current semantics and require the first character to be an uppercase > > letter (even with an accent). > > Right, I see that. But Adrián's original patch said: "The > capitalization requirements have been dropped, as they make no sense > in many alphabets" so I'm not sure why the ucfirst requirement wasn't > dropped. > > I don't know enough about other languages to comment on this, but > personally I don't see why ucfirst should be required. > > BTW, Adrián's original patch added some test cases in > beancount/parser/lexer_test.py (test_lex_unicode_account) and it seems > that was left out. > Thanks, I'll bring it back in (after I slide through this week...). -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To post to this group, send email to beancount@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/CAK21%2BhN2c_xGBEn7hu6LZQ3mcOHnezTA8bws5gv71Oqnh_UNMg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
