Hello Maetin,
On 29/11/2018 07:08, Martin Blais wrote:
> Let me get this right: you're proposing a patch that affects the parser
> layer, that has potential to break a bunch other people's stuff, and
> you're not bothering to write a test that specifically handles that case?
> This is a perfect example how not to contribute to a released open
> source project.
> I have no time for "largely untested" patches.
I think I didn't explain well enough what my idea is (however, if you
would have looked at the patch I believe you could have understood it
rather quickly).
The problem I tried to solve is that in the ingestion process, before
being serialized into a beancount file, entries are sorted by date,
type, and origin file line number. It has ben requested if the sorting
order could take into account transaction time.
The solution I proposed is to allow the ingestion machinery to accept a
datetime object for the date field. The time would be thrown out in the
serialization, but would be used for sorting. It is similar to using
time information stored in the meta field.
The implementation is simple as the only thing that needs to change is
the serialization in minimal part. After looking at the code the only
thing that needs to be done is to replace the string formatting for date
entries from ...format('{e,date} ...', e) to
...format('{e.date:%Y-%m-%d}...', e). There is no change to the parser
layer.
The patch does not come with tests because I thought to it as a better
description of the kind of solution I'm proposing, rather than something
ready to be merges.
I interpret your answer as very hostile (please correct me if this
impression is wrong). Thus I am happy that I haven't invested more time
in my attempt to contribute an idea to your project.
Best,
Dan
--
You received this message because you are subscribed to the Google Groups
"Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/beancount/f9097208-7347-1532-fcdb-5986dce3518e%40grinta.net.
For more options, visit https://groups.google.com/d/optout.
