On Thu, Nov 29, 2018 at 10:15 PM Martin Blais <[email protected]> wrote:
> On Thu, Nov 29, 2018 at 4:05 AM Oon-Ee Ng <[email protected]> wrote: > >> Thanks, that worked. I've run into a simple problem which may or may not >> be a bug. >> >> If there's non python files in the same directory, they're passed to the >> test, but not filtered by identify(). This means if I'm writing a pdf test, >> for example, and have a txt file in the same directory, the tests always >> fail. >> > > Quick question (not disingenuous): do you really need that txt file? Can > you do without? > Yes, I can. I was just surprised with that behaviour because it does not match (in my mind) what was being tested, which was the entirety of the bean-extract logic (including identify). It may be more correct to run identify() and not run >> extract/file_name/file_date/file_account if that fails. That may be out of >> scope though. >> > > It's been a while, but I cleaned up all my importer code at the same time > I ported to pytest, and IIRC I changed it so that it was unconditional. It > seemed more predictable that way. > I can have a look. > Best is if you can send an example directory that fails for you. > Fair enough, while it's always possible to imagine cases where someone might want to regression-test identify, I'd agree that it's probably not worth any maintenance work. -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/CAGQ70es_aSPqHB%3D7Tw-niAUda4Zj0ht1XRF74BiUkDg5YLTHyA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
