On Sun, Jun 2, 2019 at 7:05 PM Daniele Nicolodi <[email protected]> wrote:

> On 02/06/2019 16:16, Martin Blais wrote:
> > Thanks Dan,
> > I fixed most of the issues I had with these changes:
>
> Nice! Which issues do remain?
>

Give me a few days to run this myself and see if I encounter anything, then
I'll merge.

Just the font-locking on the section headings would be super nice to have,
but it's not absolutely necessary.


> > (require 'beancount)
> > (setq beancount-outline-regexp "\\*+ ")
>
> Yeah, I forgot to escape the * in the regexp...
>
> > (define-key* beancount-mode-map [(control c)(control n)]
> > 'outline-next-visible-heading)
> > (define-key* beancount-mode-map [(control c)(control p)]
> > 'outline-previous-visible-heading)
>
> I'm hesitating to add those binding to to beancount.el as I would need
> to find a way to make that conditional to having outline-minor-mode
> loaded. What do you think?
>

No need to; I and others can just add them locally in our configs if
desired.



>
> > (add-hook 'beancount-mode-hook 'outline-minor-mode)
> >
> >
> > I have a question. Is there a way to bring back the font-lock coloring
> > for the outline headings?
> > With or-mode their distinguished color made it really salient which
> > level they're at.
> > I'm seeing them all white.
>
> I don't think outline-minor-mode provides fontification for headings.
> But it should not be hard to add it. I'll look into this.
>

Please, that visual  really makes it clear.
But it's not an absolute must.

Thank you for this, give me a bit of time and I'll merge this for sure.




>
> Cheers,
> Dan
>
> --
> You received this message because you are subscribed to the Google Groups
> "Beancount" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/beancount/3ff25066-b8eb-cc4e-5b60-ed745c4ce8a1%40grinta.net
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/beancount/CAK21%2BhP0YGiV%2B%3DGmo3uPHsWRZqQCkiaUBwsOpQWK8irSivqG9w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to