Hello Stefan, On 17-12-2019 16:05, Stefan Monnier wrote: > I finally got around to merging the patches I used to use with the old > (minor-mode) version of beancount.el into the new version.
Thank you very much for the patch. Do you mind if I split it in a few commits and I submit it with a few tweaks and your attribution as a merge request on bitbucket, so that Martin can easily merge it? > - Remove the redundant `:group`s (since they default to the last > `defgroup` anyway). I didn't know about this feature. > - New var `beancount-electricity` to control behavior of RET. > When non-nil, RET at the end of a leg adds the currency if missing (or > tries to anyway: I think it's done in a too naive way which doesn't > account for the many ways to specify the amount). I think this should be called `beancount-electric-currency` instead. Can you be more specific about how this may not work for more complex ways of specifying the amount? > - Comment out a `defvar` of `beancount-directive-names` that doesn't do > anything since it's preceded by a `defconst` of the same var. I'll remove it all together. > - Add a M-RET binding that inserts the date part of a new transaction. I don't enter many transactions manually, but this addition seems reasonable. What about a M-S-RET binding that asks for the transaction date with org-read-date (using the calendar to choose the date)? > - Fix `beancount-collect`: the old code collects all matches and then > its callers removed the entry found at point (because that entry is > the one we're in the process of completing so it's presumably not > (yet) valid) but that misbehaves when the entry at point is actually > already valid, in which case that entry is incorrectly removed from > the possible completions. So instead I changed `beancount-collect` so > it ignores matches around point which usually gives the same result > except when the match around point is *also* found elsewhere (in which > case the new code keeps that completion whereas the old one > incorrectly discarded it). Good catch! Thank you. Cheers, Dan -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/4d0f3014-be23-a36c-ac10-18f859d4dbf9%40grinta.net.
