How about we change the defaults, but provide a function one can call to add the current disallowed ones? The rationale for this being that by default the mode would be compliant (and I suppose can be more easily packaged places) but those who can't be bothered with the change could quickly restore things to how they were with minimal effort.
On Tue, Oct 6, 2020 at 4:07 PM Karl Fogel <[email protected]> wrote: > Hi, everyone. As per https://github.com/beancount/beancount/issues/333, > I'd like to propose that we change the default Emacs keybindings in > beancount.el. > > The change is simply to replace each > > Control-c LETTER > > with > > Control-c Control-LETTER > > in `beancount-mode-map'. > > Justification: the current bindings violate the Emacs keybinding > guidelines. In Emacs, "Control-c LETTER" is reserved for users' custom > bindings (many of us depend on that convention being observed) while > "Control-c Control-LETTER" is specifically reserved for modes -- like > `beancount-mode'. Since by default `beancount-mode-map' is on Control-c > and binds many plain letters, it's currently violating those conventions. > > Since there *is* a space under Control-c that's explicitly reserved for > modes' custom bindings, let's keep `beancount-mode-map' on that key and > simply use that designated space (namely, Control-LETTER). > > Further details are in the issue. > > I'm happy to provied the patch, but first I wanted to ask if anyone > objects to this change, or wants to discuss it first. > > Best regards, > -Karl > > -- > You received this message because you are subscribed to the Google Groups > "Beancount" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/beancount/87eembf79n.fsf%40red-bean.com. > -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/CAK21%2BhNOq5h_HZcWL%2B3rrbegy-1vqhEMbd8AXkF0aAqhAHF8hg%40mail.gmail.com.
