Hello,
thank you for letting me know of this concurrent effort. I had a quick
look at your implementation and I noticed a few important things:
1. as far as I can tell, it does not handle indentation correctly, it
just ignores it,
2. it does not correctly work with account names in the whole Unicode
range, it mimics the hack implemented for
3. it mimics too closely the Yacc grammar, resulting in a parse tree
structure that seems hard to work with both because of the node nesting
and to what nodes are exposed,
4. less important: I don't like how you choose to handle org-mode like
sectioning having Beancount directive nested into section nodes. I don't
think is compatible with how Emacs handles sectioning.
On the other hand, it adds field names to some node, something that my
grammar does not yet to.
If you want to collaborate on this, I'm more than happy to add any
structure to the parse nodes emitted by my version of the grammar to
make it suitable to be used in your use cases. But I think it is better
to start with a correct and clean parser.
Cheers,
Dan
On 26/01/2023 14:43, polarmutex wrote:
forgot link to repo: https://github.com/polarmutex/tree-sitter-beancount
On Thursday, January 26, 2023 at 8:41:49 AM UTC-5 polarmutex wrote:
i also wrote a tree-sitter grammar a while ago and have it
officially submitted to nvim-treesitter , nix package manager, and
use it in my beancount lsp. I am happy to work to gather to merge in
changes but think we should work together. I would rather move my
repo to the group.
On Thursday, January 26, 2023 at 7:47:38 AM UTC-5 [email protected]
wrote:
On 24/01/2023 03:17, Martin Blais wrote:
> I would be happy to move this project to the beancount Github
> organization. Martin, can you arrange for a project to be
created
> and to give me owner rights for it? Thank you!
>
>
> You got it
> https://github.com/beancount/tree-sitter-beancount
<https://github.com/beancount/tree-sitter-beancount>
Thank you Martin. However, reading GitHub documentation it makes
more
sense to transfer my repository to the beancount organization
rather
than creating a new repository.
If you delete beancount/tree-sitter-beancount I'll setup the
transfer.
Thank you.
Cheers,
Dan
--
You received this message because you are subscribed to the Google
Groups "Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected]
<mailto:[email protected]>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/beancount/89848b9c-0d5b-4142-a2f6-5d9acec7fbaan%40googlegroups.com <https://groups.google.com/d/msgid/beancount/89848b9c-0d5b-4142-a2f6-5d9acec7fbaan%40googlegroups.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/beancount/874edab3-8a1f-7835-17b3-155e00c0d395%40grinta.net.
