> are you open to accepting minor fixes to the documentation? Eg: _print_model(file) wasn’t defined in the examples page
Fixed in 3b31cf47 <https://github.com/SEIAROTg/autobean-refactor/commit/3b31cf47a2cfb469b17a35992bd3803de1ea0093>. Issues and PRs are also very welcomed! > an idea to consider: turning class _FilesFormatter into an iterator and/or a context manager and including it in the base project (autobean_refactor) might allow people to avoid having to write boilerplate code, and simply write a couple lines of python code to accomplish what they want quickly That's a very good idea. Added in c308958b <https://github.com/SEIAROTg/autobean-refactor/commit/c308958b574f85ffd066960ac2dac6ecd472b00f> and documented here <https://autobean-refactor.readthedocs.io/en/latest/getting-started.html#in-place-editing>. There was actually an undocumented parse_file_recursive <https://github.com/SEIAROTg/autobean-refactor/blob/3b31cf47a2cfb469b17a35992bd3803de1ea0093/autobean_refactor/parser.py#L140> created for autobean-format but ended up not being used as the latter needs the original text to support the diff function. On Friday, June 30, 2023 at 8:42:17 PM UTC+1 Red S wrote: > I noticed already and I’ve been using that documentation :). I’m finding > both the documentation and code to be great: clean, easily understood, well > thought out, and behaves exactly as expected. Thank you for sharing! > > A couple thoughts: > > - are you open to accepting minor fixes to the documentation? Eg: > _print_model(file) wasn’t defined in the examples page > - an idea to consider: turning class _FilesFormatter into an iterator > and/or a context manager and including it in the base project > (autobean_refactor) might allow people to avoid having to write > boilerplate > code, and simply write a couple lines of python code to accomplish what > they want quickly > > > > > On Friday, June 30, 2023 at 6:40:00 AM UTC-7 [email protected] wrote: > >> Author of autobean-refactor here. Glad to see it being useful! >> >> Besides, there is now some documentation here: >> https://autobean-refactor.readthedocs.io/. >> >> On Thursday, June 29, 2023 at 11:11:52 PM UTC+1 Red S wrote: >> >>> Vanguard at some point started repeating their memo strings in some of >>> their ofx files, so they look like this: 'DIVIDEND REINVESTMENTDIVIDEND >>> REINVESTMENT'. >>> >>> I added a fix >>> <https://github.com/redstreet/beancount_reds_importers/commit/51280cd888b719147c0dc7e382dd97b6ff7b8e0e> >>> >>> in beancount_reds_importers >>> <https://github.com/redstreet/beancount_reds_importers>. However, this >>> has been going on for a while, and I wanted to go fix my beancount files >>> from prior imports. While there are several simple ways to accomplish this, >>> I used autobean.refactor >>> <https://groups.google.com/g/beancount/c/v_SXiyhQWfs/m/cR96x43LAwAJ> since >>> it has the highest level understanding of beancount files, and because I've >>> been using it for other things. >>> >>> Note that I don't use a single beancount file, but one per per account >>> <https://reds-rants.netlify.app/personal-finance/ledger-filing-hierarchy/> >>> . >>> >>> Since this is a good hello-world-ish example, I thought I'd share my >>> code to help others kickstart their reformats/refactors. *Here's the >>> gist* >>> <https://gist.github.com/redstreet/251e3c886c74093881e836941e839ed8>. >>> Most of it is stolen from autobean.format here >>> <https://github.com/SEIAROTg/autobean-format/blob/main/autobean_format/main.py> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/6fcf3a54-5401-48e8-ad9f-271e3d1d1763n%40googlegroups.com.
