- There's no dev list, this is it, not enough traffic to justify a separate list. - Your feature touches a very sensitive part of the booking process - one I've struggled to get sort of right in the past, has a lot of weird corner cases, it's been a bit of a whack-a-mole situation - I'd have to really immerse myself back into this to give it proper review, and I don't have time for a while. - I would suggest adding unit tests for the specific changes it improves would be very useful to that effect. - In the meantime I'm happy to create for you a permanent branch in the beancount repo itself to track this, or perhaps even better, to install a conditional in the master branch with an option that dispatches between the two implementations. - The cheap (time-boxed) and easy thing I could do could be to ensure before/after results match. LMK what you'd like to do,
On Thu, Apr 11, 2024 at 12:10 PM Eric Altendorf <[email protected]> wrote: > I have revisited the work I did earlier to tweak Beancount to propagate > cost basis with asset transfers. (As has been discussed, this is a bit of > a corner case in general, but is actually very common and important for > capital gains calculations for cryptocurrency assets, since they are > frequently transferred between accounts.) > > Digging through my git repo, it looks like what I did was this: > > https://github.com/beancount/beancount/compare/master...ericaltendorf:beancount:cost-transfer?expand=1 > > I would appreciate some feedback on whether this generally looks like the > right approach, as well as any shortcomings that would need to be addressed > before I can send a PR to merge it into Beancount proper. > > Thanks, > Eric > > (Is there a "beancount-dev" list that would be better to send this to? :) > > > -- > You received this message because you are subscribed to the Google Groups > "Beancount" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/beancount/CAFXPr0u1vHW-5C32d_LvpgWXTd_quhsk-UGP8U%2BO8VU9syj3xw%40mail.gmail.com > <https://groups.google.com/d/msgid/beancount/CAFXPr0u1vHW-5C32d_LvpgWXTd_quhsk-UGP8U%2BO8VU9syj3xw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/CAK21%2BhMuNzXX61TJqRawP3Cq-jK8U1Weokra9rmd19PCMbYBkw%40mail.gmail.com.
