I confirm, that the new test works on Windows
thanks for fixing!

On Tuesday, November 26, 2024 at 11:50:30 PM UTC+1 [email protected] wrote:

> On 23/11/24 14:20, Chary Ev2geny wrote:
> > Dear all,
> > 
> > i never really had a use for the *document *directive, but as I now 
> > logged an issue  with it https://github.com/beancount/beancount/ 
> > issues/874 I am kind of trying to dig in it, hence questions.
>
> There is no issue in how the document directive work. Everything works 
> as intended. The issue is with the test. I prepared an PR that fixes 
> this (and a couple of other) tests when ran on Windows. See 
> https://github.com/beancount/beancount/pull/876 The commits there have 
> all the details.
>
> It can be debated that how things are intended to work is the best or 
> most obvious, but any change would be an incompatible change to how the 
> entries printing code works. For example it would break some of mine 
> that programmatically adds document directives. I am not aware of any 
> issue issue filed about the behavior of this part of the code, thus I 
> don't really see reason to change it.
>
> Cheers,
> Dan
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/beancount/94617659-b999-4216-87cd-cf70fa179c78n%40googlegroups.com.

Reply via email to