The fix looks good for me.
Thanks,
Alexandr.
On 5/28/2013 9:58 PM, Seán Coffey wrote:
Sergey,
Get code review from Alexander or others before pushing. You can
consider this still approved for jdk7u-dev.
regards,
Sean.
On 28/05/2013 17:30, sergey malenkov wrote:
Hi Seán and Alexander,
I realized that the Executable class does not exist in JDK 7,
so it is impossible to remove the following methods:
protected abstract Class<?>[] getParameters(T method);
protected abstract boolean isVarArgs(T method);
So I created a new webrev for 7u to review:
http://cr.openjdk.java.net/~malenkov/8013416.7.0/
<http://cr.openjdk.java.net/%7Emalenkov/8013416.7.0/>
It fixes the issue, but it differs from the following one:
http://cr.openjdk.java.net/~malenkov/8013416.8.0/
<http://cr.openjdk.java.net/%7Emalenkov/8013416.8.0/>
The issue can be found here:
http://bugs.sun.com/view_bug.do?bug_id=8013416
Could you please approve the modified fix?
Thanks,
SAM
On 24.05.2013 21:06, Seán Coffey wrote:
Ah, I'd missed the beans-dev mailing list!
http://mail.openjdk.java.net/pipermail/beans-dev/2013-May/000042.html
Approved.
regards,
Sean.
On 24/05/13 17:58, sergey malenkov wrote:
Hi Seán,
I've attached the mail from the approver.
Thanks,
SAM
On 24.05.2013 20:48, Seán Coffey wrote:
Sergey,
jbs.oracle links aren't useful on OpenJDK mails.
Here's the external link :
http://bugs.sun.com/view_bug.do?bug_id=8013416
I can't find the review thread. Can you add it to your request ?
regards,
Sean.
On 24/05/13 17:09, sergey malenkov wrote:
Hi all,
Could you please approve the backport of JDK-8013416 to JDK 7u-dev?
Java Bean Persistence with XMLEncoder
https://jbs.oracle.com/bugs/browse/JDK-8013416
Earlier the fix was prepared, approved and pushed into JDK8:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6b29c27d0807
The fix for JDK 7u-dev is the same and doesn't contain any changes.
Note that this is a regression.
Thanks,
SAM
