2009/10/16 Keith Rarick <[email protected]>: > > On Thu, Oct 15, 2009 at 5:27 AM, Philip Ross <[email protected]> wrote: >> I'm using beanstalkd 1.4.1 and have found a reproducible scenario that >> appears to write corrupt data to the binlog such that beanstalkd can't >> restart. > > I'm trying to make a unit test for this, but so far I can't actually > reproduce it. Do you mind checking out > http://github.com/kr/beanstalkd/tree/binlog-read-bug and running "make > check"? Hopefully the test sh-tests/binlog-read.sh will fail and > expose the bug. For me, this test unexpectedly passes.
enqueue_job only writes the job to the binlog on release if there is a delay. Your test case was releasing with a delay of 0, so nothing was written to the binlog and the bug didn't get triggered. I've attached a patch that changes the delay to 1 and sleeps a little bit longer before restarting beanstalk so that the job can be picked up with the release. With the patch I get a segmentation fault as expected with the 1.4.1 version of binlog.c. The test passes with the fix applied. Regards, Phil --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "beanstalk-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/beanstalk-talk?hl=en -~----------~----~----~----~------~----~------~--~---
fix_binlog_read_test.patch
Description: Binary data
