> There's one other bit missing though. WIth the old proxy interface, signal
> connections always come in (connect+disconnect) pairs
> I.e. you have replaced proxy_connect() with on(), added an event handler
> disconnect via =NULL but forgot to remove the proxy_disconnect line for
> track_view_repeat_changed that belongs to the proxy_connect() you removed.
Fixed.
> Also please reword "/* disconnect */" to be more explicit: "// disconnects
> event handlers"
Fixed.
Not sure if you wanted the fixes in an extra commit (I did this) or squashed
into the previous commit and delivered as non-linear push.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/64#issuecomment-415386077
_______________________________________________
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast
