Thanks for the PR, a couple comments:
> + SfiInt lleft = self->song.loop_left();
Use just int, float, etc in new code, instead of gint or SfiInt.
> + BseSong *self = const_cast<SongImpl*> (this)->as<BseSong *>();
This should be "as<BseSong*>", without the extra space.
> + bool loop_enabled = self->loop_enabled_SL;
You're saving an old value here for comparing later. There's no need to keep
this a variable, i.e. please make that const in similar code in the future:
+ const bool loop_enabled = self->loop_enabled_SL;
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/65#issuecomment-416056536_______________________________________________
beast mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/beast
