Thanks a lot Stefan.
I'm not sure that "TPQN" is any better than "Ticks" for users at the UI, at
least I'm not aware of another sequencer that has TPQN labels... I think in
either case users will need the tooltip to decipher what the property is about.
There's one other thing I noticed during review. With the old GParamSpec +
GObject based property API, the GObject machinery ensures that the GValue
passed in to property setters complies with the GParamSpec value range. With
our IDL API, nothing like that is enforced anymore. That means, an int32
property between 1-256 can now be set to 0 or -2^31 through the API. For a
denominator to become 0 that could affect stability.
Please keep that in mind for ported properties and watch out if we shouldn't
add extra guards, like:
denominator = CLAMP (input, 0, 256)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/69#issuecomment-417492287
_______________________________________________
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast
