This is the first string property port that uses the `APPLY_IDL_PROPERTY` macro. Since there is no version of `constrain_idl_property` for strings, your code didn't compile when instantiated with strings. So I used C++17 `if constexpr` for checking for the type which compiles now. This means strings are not constrained (and all other types). If that wasn't your intention when writing the code, probably a String specialization of `constrain_idl_property` would be better.
I preserved the quark setting/getting (no idea why it is done this way in the first place). However I wonder if SuperImpl shouldn't simply have two string members, one for author and one for license. You can view, comment on, or merge this pull request online at: https://github.com/tim-janik/beast/pull/110 -- Commit Summary -- * BSE: bseitem: allow APPLY_IDL_PROPERTY for Strings and other types * BSE: Super: port author/license properties to C++ -- File Changes -- M bse/bseapi.idl (2) M bse/bseitem.hh (2) M bse/bsesuper.cc (95) M bse/bsesuper.hh (7) -- Patch Links -- https://github.com/tim-janik/beast/pull/110.patch https://github.com/tim-janik/beast/pull/110.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tim-janik/beast/pull/110
_______________________________________________ beast mailing list [email protected] https://mail.gnome.org/mailman/listinfo/beast
