Author: ekoneil
Date: Wed Mar 16 09:58:38 2005
New Revision: 157780
URL: http://svn.apache.org/viewcvs?view=rev&rev=157780
Log:
JIRA fix:
BEEHIVE-424 Internal error in RepeaterComponent.java:184
This deletes some errant calls to clearBody.
BB: self
BVT: NetUI pass
Modified:
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/Repeater.java
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/RepeaterComponent.java
incubator/beehive/trunk/netui/test/webapps/drt/testRecorder/tests/pfPageInput.xml
Modified:
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/Repeater.java
URL:
http://svn.apache.org/viewcvs/incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/Repeater.java?view=diff&r1=157779&r2=157780
==============================================================================
---
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/Repeater.java
(original)
+++
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/Repeater.java
Wed Mar 16 09:58:38 2005
@@ -503,14 +503,6 @@
protected void localRelease() {
super.localRelease();
- // This is a work around in Tomcat where clearBody() throwns an
internal exception
- // because the BodyContent tag is pooled and under certain situtions
the pooled object has been
- // flushed.
- try {
- if(bodyContent != null) bodyContent.clearBody();
- } catch(Exception ignore) {
- }
-
_currentItem = null;
_currentIndex = -1;
_iterator = null;
Modified:
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/RepeaterComponent.java
URL:
http://svn.apache.org/viewcvs/incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/RepeaterComponent.java?view=diff&r1=157779&r2=157780
==============================================================================
---
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/RepeaterComponent.java
(original)
+++
incubator/beehive/trunk/netui/src/tags-databinding/org/apache/beehive/netui/tags/databinding/repeater/RepeaterComponent.java
Wed Mar 16 09:58:38 2005
@@ -17,8 +17,11 @@
*/
package org.apache.beehive.netui.tags.databinding.repeater;
+import java.io.IOException;
import javax.servlet.jsp.JspException;
+import javax.servlet.jsp.JspWriter;
import javax.servlet.jsp.tagext.Tag;
+import javax.servlet.jsp.tagext.BodyContent;
import org.apache.beehive.netui.tags.AbstractClassicTag;
import org.apache.beehive.netui.util.Bundle;
@@ -142,6 +145,7 @@
the error reporting
*/
if(hasErrors()) {
+ /* bug: this doesn't report errors */
localRelease();
return EVAL_PAGE;
}
@@ -175,15 +179,6 @@
*/
protected void localRelease() {
super.localRelease();
-
- // This is a work around in Tomcat where clearBody() throwns an
internal exception
- // because the BodyContent tag is pooled and under certain situtions
the pooled object has been
- // flushed.
- try {
- if(bodyContent != null)
- bodyContent.clearBody();
- } catch(Exception ignore) {}
-
_repeater = null;
}
Modified:
incubator/beehive/trunk/netui/test/webapps/drt/testRecorder/tests/pfPageInput.xml
URL:
http://svn.apache.org/viewcvs/incubator/beehive/trunk/netui/test/webapps/drt/testRecorder/tests/pfPageInput.xml?view=diff&r1=157779&r2=157780
==============================================================================
---
incubator/beehive/trunk/netui/test/webapps/drt/testRecorder/tests/pfPageInput.xml
(original)
+++
incubator/beehive/trunk/netui/test/webapps/drt/testRecorder/tests/pfPageInput.xml
Wed Mar 16 09:58:38 2005
@@ -2,7 +2,7 @@
<ses:recorderSession
xmlns:ses="http://beehive.apache.org/netui/tools/testrecorder/2004/session";>
<ses:sessionName>pfPageInput</ses:sessionName>
<ses:tester>rich</ses:tester>
- <ses:startDate>18 Jan 2005, 06:51:25.843 PM MST</ses:startDate>
+ <ses:startDate>16 Mar 2005, 10:13:04.442 AM MST</ses:startDate>
<ses:description>rich</ses:description>
<ses:tests>
<ses:test>
@@ -18,7 +18,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -44,7 +44,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -64,7 +64,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -99,7 +99,7 @@
</html>]]></ses:responseBody>
</ses:response>
<ses:testResults>
- <ses:testStatus>fail</ses:testStatus>
+ <ses:testStatus>pass</ses:testStatus>
</ses:testResults>
</ses:test>
<ses:test>
@@ -115,7 +115,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -141,7 +141,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -161,7 +161,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -196,7 +196,7 @@
</html>]]></ses:responseBody>
</ses:response>
<ses:testResults>
- <ses:testStatus>fail</ses:testStatus>
+ <ses:testStatus>pass</ses:testStatus>
</ses:testResults>
</ses:test>
<ses:test>
@@ -212,7 +212,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -238,7 +238,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -258,7 +258,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -301,7 +301,7 @@
</html>]]></ses:responseBody>
</ses:response>
<ses:testResults>
- <ses:testStatus>fail</ses:testStatus>
+ <ses:testStatus>pass</ses:testStatus>
</ses:testResults>
</ses:test>
<ses:test>
@@ -317,7 +317,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -343,7 +343,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -363,7 +363,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -398,7 +398,7 @@
</html>]]></ses:responseBody>
</ses:response>
<ses:testResults>
- <ses:testStatus>fail</ses:testStatus>
+ <ses:testStatus>pass</ses:testStatus>
</ses:testResults>
</ses:test>
<ses:test>
@@ -414,7 +414,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -440,7 +440,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -460,7 +460,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -495,7 +495,7 @@
</html>]]></ses:responseBody>
</ses:response>
<ses:testResults>
- <ses:testStatus>fail</ses:testStatus>
+ <ses:testStatus>pass</ses:testStatus>
</ses:testResults>
</ses:test>
<ses:test>
@@ -511,7 +511,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -537,7 +537,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -557,7 +557,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -599,7 +599,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -625,7 +625,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -645,7 +645,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -687,7 +687,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -713,7 +713,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -733,7 +733,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -775,7 +775,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -801,7 +801,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -821,7 +821,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -863,7 +863,7 @@
<ses:cookies>
<ses:cookie>
<ses:name>JSESSIONID</ses:name>
- <ses:value>401BA83031A94CBDA416B26EB0A88FB5</ses:value>
+ <ses:value>1D169E462AAA1A75EC771AA2EBD51A21</ses:value>
</ses:cookie>
</ses:cookies>
<ses:headers>
@@ -889,7 +889,7 @@
</ses:header>
<ses:header>
<ses:name>cookie</ses:name>
- <ses:value>$Version=0;
JSESSIONID=401BA83031A94CBDA416B26EB0A88FB5; $Path=/coreWeb</ses:value>
+ <ses:value>$Version=0;
JSESSIONID=1D169E462AAA1A75EC771AA2EBD51A21; $Path=/coreWeb</ses:value>
</ses:header>
<ses:header>
<ses:name>cookie2</ses:name>
@@ -909,7 +909,7 @@
</ses:header>
<ses:header>
<ses:name>testrecorder.playback.testid</ses:name>
- <ses:value>-54834ffa:101889e165b:-7ae8</ses:value>
+ <ses:value>-621dc6f6:102ac533be8:-79ca</ses:value>
</ses:header>
<ses:header>
<ses:name>user-agent</ses:name>
@@ -945,6 +945,7 @@
pi3:
<ul>
+
subarray: <ul>
<li><span>hi</span></li>
@@ -979,9 +980,9 @@
</ses:testResults>
</ses:test>
</ses:tests>
- <ses:endDate>18 Jan 2005, 06:51:28.640 PM MST</ses:endDate>
+ <ses:endDate>16 Mar 2005, 10:13:06.596 AM MST</ses:endDate>
<ses:sessionStatus>fail</ses:sessionStatus>
<ses:testCount>10</ses:testCount>
- <ses:passedCount>4</ses:passedCount>
- <ses:failedCount>6</ses:failedCount>
+ <ses:passedCount>9</ses:passedCount>
+ <ses:failedCount>1</ses:failedCount>
</ses:recorderSession>
