Re: test recorder patch

[Eddie O'Neil]

 Cool, thanks!
 For those who are curious, the test recorder used to depend on the 
Page Flow scoping code and has now switched to use 
javax.servlet.http.HttpServletRequestWrapper.  Now that the test 
recorder runs on the latter, it has broken its dependence on the NetUI 
runtime, which is good since it's just generic webapp test 
infrastructure that isn't tied to the JPF runtime at all.  This removes 
them from the classpath for build / runtime and gets the test recorder 
build running on JDK 1.4.

 I'm rolling these into SVN now.
Eddie

Patrick Osborne wrote:
Hi,
Below are a couple of diffs to the Test Recorder that remove unused 
jars and add support for jdk1.4.

Thanks,
Patrick.
D:\dev\beehive\trunk\netui\test\ant>svn diff test.properties
Index: test.properties
===================================================================
--- test.properties     (revision 30790)
+++ test.properties     (working copy)
@@ -78,8 +78,6 @@
${deployed.httpClient.jar};\
${deployed.test-recorder.jar};\
${deployed.commons-logging.jar};\
-${deployed.util.jar};\
-${deployed.scoping.jar};\
${servlet24.jar};\
${log4j.jar};\
${xbean.jar};\

D:\dev\beehive\trunk\netui\test\src\testRecorder>svn diff build.xml
Index: build.xml
===================================================================
--- build.xml   (revision 30790)
+++ build.xml   (working copy)
@@ -2,7 +2,7 @@
<project name="Beehive/NetUI/testRecorder" default="compile" basedir=".">
-    <property name="module.classpath" 
location="${deployed.junit.jar};${deployed.httpClient.jar};${deployed.commons-log 

ging.jar};${deployed.util.jar};${deployed.scoping.jar};${log4j.jar};${servlet24.jar};${jsp20.jar};${xbean.jar};${junit.j 

ar}"/>
+    <property name="module.classpath" 
location=";${deployed.httpClient.jar};${deployed.commons-logging.jar};${log4j.jar 

};${servlet24.jar};${jsp20.jar};${xbean.jar};${junit.jar}"/>
   <property name="module.classes.dir" 
location="${qa.classes.dir}/${module.name}"/>
   <property name="module.jar.name" value="${test-recorder.jar.name}"/>
   <property name="module.jar" 
location="${qa.lib.dir}/${module.jar.name}"/>
@@ -26,6 +26,7 @@
              classpath="${module.classpath}"
              debug="${compile.debug}"
              deprecation="${compile.deprecation}"
+               source="${compile.source}"
              optimize="${compile.optimize}">
              <include name="**/*.java"/>
       </javac>


D:\dev\beehive\trunk\netui\test\src\testRecorder\org\apache\beehive\netui\tools\testrecorder\client>svn 
diff Master*
Index: MasterTestRecorderJUnitTest.java
===================================================================
--- MasterTestRecorderJUnitTest.java    (revision 30790)
+++ MasterTestRecorderJUnitTest.java    (working copy)
@@ -206,7 +206,7 @@
   }

   private static boolean getDeleteResultsProperty() {
-        return Boolean.parseBoolean( getProperty( 
DELETE_RESULTS_PROPERTY ) );
+        return Boolean.valueOf( getProperty( DELETE_RESULTS_PROPERTY 
) ).booleanValue();
   }

   private static String getTestsProperty() {
@@ -222,7 +222,7 @@
   }
   private static boolean getAllProperty() {
-        return Boolean.parseBoolean( getProperty( ALL_PROPERTY ) );
+        return Boolean.valueOf( getProperty( ALL_PROPERTY ) 
).booleanValue();
   }

   private static String getProperty( String prop ) {