What are the features that you copied from Catalina? I think if we take these classes, we should repackage them so we avoid conflicts with Tomcat. I do agree that taking a hard dependency on catalina.jar is not a good idea because the goal is to run on all servlet containers. Who knows what trouble we may have is catalina.jar starts to show up on the class path for other servlet containers.
There are many features that are duplicated in projects (I believe there are three Base64 encoding classes in the core NetUI project at the moment, JSF reference implementation, XMLBeans and Catalina). I think if these features are generic enough, we can push to move them from catalina.jar into commons. On Wed, 24 Nov 2004 12:23:24 +0900, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Hi Michael, > > I was gonna take the way you said, but there were some considerations. > > The classes borrowed are only from Tomcat and they reside in catalina.jar. > > The catalina.jar file is really huge. > That's a subtle problem but can be one reason. > And there's another reason which is critical I guess. > If the catalina.jar is required for Beehive and > one deploys a web service app with catalina.jar > (WEB-INF/lib/catalina.jar) in Axis running on Tomcat, > it might (obviously?) cause classloading problems. > The one must be careful catalina.jar will be go into > the directory. > > On the other hand, if one deploy a web service in Axis running on the > servlet container other than Tomcat, catalina.jar must be copied > into WEB-INF/lib directory. > > I thought that would confuse developers...so I borrowed > the source files and commented "copied from Tomcat" in the all files. > > There's a way we can avoid this. > Implement all classes from a scratch by myself. > ( I just didn't want re-invent the wheel. ) > > Thanks in advance. > > Wolfgang. > >
