Rich,
Thanks for the code check in and for the comments. I think you're right on both comments. I forgot to change the Jpf.MessageArg interface after decision to use an implied position rather than require it. I can make both those changes and add another patch here.
Thanks, Carlin
Rich Feit (JIRA) wrote:
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
Rich Feit reassigned BEEHIVE-262: ---------------------------------
Assign To: carlin rogers (was: Rich Feit)
Hey Carlin, I submitted this patch (thanks!). I have two questions for you before we close out this issue:
1) In BaseValidationRuleGrammar, you removed the following two lines from the condition for adding the using-default-display-name warning. < && CompilerUtils.getString( annotation, ARG0_ATTR, true ) == null < && CompilerUtils.getString( annotation, ARG0_KEY_ATTR, true ) == null I think this means that we'll always get the warning, even when there *is* an argument at position 0. Shouldn't this condition be replaced with logic that goes against the array of MessageArg annotations?
2) Also, in GenValidationModel.java, you've got code for inferring the position from the position in the array (which I support). But in the definition for @Jpf.MessageArg (in Jpf.java), position() is required. I think it should instead default to -1, which should make your code in GenValidationModel work unchanged. What do you think?
update the JPF declarative validation to support commons validator v1.1 -----------------------------------------------------------------------
Key: BEEHIVE-262 URL: http://issues.apache.org/jira/browse/BEEHIVE-262 Project: Beehive Type: Task Components: NetUI Versions: V1Beta Reporter: carlin rogers Assignee: carlin rogers Fix For: V1Beta Attachments: patch.tar.gz, patch.tar.gz
The current implementation of the NetUI declarative validation only supports version 1.0 of the commons validator. Need to update the source and schema to support v1.1.
