Sorry, the OrderItem.java file should not have been in the forms
directory. I've updated the zip file (but I couldn't figure out how to
remove the other zip file).

As to the initDB.sql file, I plan to remove the code to init the DB and
add manual instructions for initializing the DB, so for now I would like
to leave it in the resources directory.  

Scott

-----Original Message-----
From: Eddie O'Neil 
Sent: Tuesday, April 12, 2005 10:18 AM
To: Beehive Developers
Subject: Re: Pending JPetStore Checkin

Scott--

   Couple of comments:

- having patched my local copy of petstoreWeb, the build.xml file in
WEB-INF/src doesn't work with the targets "clean build".  It fails
because the OrderItem.java file in WEB-INF/src is duplicated in two
directories:

   org/apache/beehve/samples/petstore/model
                                     /forms

with the same package:

   org.apache.beehive.samples.petstore.model

and this is causing APT to fail with an NPE.

- the file resources/sql/initDB.sql is in the webapp root.  I think that
this needs to move to WEB-INF/src and be copied by the build file so
that it's available in WEB-INF/classes in classloader at runtime.

   Can you update the patch?

Thanks!

Eddie



Scott Semyan wrote:
> JIRA:  BEEHIVE-518 
> 
> -----Original Message-----
> From: Steven Tocco
> Sent: Tuesday, April 12, 2005 9:45 AM
> To: Beehive Developers
> Subject: RE: Pending JPetStore Checkin
> 
> I suspect this work will be attached to a JIRA issue with the patch 
> file, additions, deletions.
> 
> Correct?
> 
> Steve
> 
> -----Original Message-----
> From: Scott Semyan
> Sent: Tuesday, April 12, 2005 10:44 AM
> To: Beehive Developers
> Subject: Pending JPetStore Checkin
> 
> I have a pending checkin to the JPetStore sample. This check-in 
> incorporates using Derby as the data store and adds new or improved 
> functionality such as multiple addresses, add/edit new user, admin of 
> the DB, etc. I also fixed many bugs.
>  
> This checkin is currently being code reviewed and should appear in the

> trunk shortly.
>  
> Scott Semyan
>  
> 
> 
> 
> 



Reply via email to