[ http://issues.apache.org/jira/browse/BEEHIVE-135?page=all ]
Kenneth Tam resolved BEEHIVE-135:
---------------------------------
Resolution: Fixed
Fixed as of rev 164613. I am persuaded that hard reference between downstream
JCXs and the base interface doesn't really increase coupling, since typically
all downstream JCXs will already require hard references to that base interface
in the form of references to propertyset annotations.
> Version checking codegen cleanup
> --------------------------------
>
> Key: BEEHIVE-135
> URL: http://issues.apache.org/jira/browse/BEEHIVE-135
> Project: Beehive
> Type: Bug
> Components: Controls
> Versions: V1Alpha
> Reporter: Kyle Marvin
> Assignee: Kenneth Tam
> Priority: Minor
> Fix For: V1
>
> The code generated static initialization code that does version checking for
> ControlBeans could be made better in a couple of ways:
> - the code generated by the enforceVersionRequired macro should be
> selectively generated. There is no reason to generate class load time
> version checking if there is no @VersionRequired annotation on the associated
> ControlExtension.
> - the ControlInterface to version check against can be (and should) be
> determined at codegen time and not runtime. The call to
> ControlBean.getMostDerivedInterface can be replaced by directly injecting the
> (versioned) ControlInterface class name. This is a) simpler, and b) safer,
> because having the class you are version checking against be dynamic doesn't
> really make sense.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
