I did it. Check them out. Τη Δευτέρα, 27 Μαρτίου 2017 - 12:54:45 π.μ. UTC+3, ο χρήστης Adrian Sampson έγραψε: > > Hi! Let’s continue this discussion on the pull request thread, if you > don’t mind. (As a little bit of background, this keeps things organized and > lets anyone weigh in—I’m not the sole arbiter of what goes into beets!) > > Can you push your changes to the branch so we can see them in the PR > display? > > On Mar 26, 2017, at 5:49 PM, Spiros C <[email protected] <javascript:>> > wrote: > > Adrian, I put the print(\a) in the right place as you told me and > everything works perfectly.I also fixed my comment as you said. Could help > me a little bit on how to put this new functionality behind a configuration > option? > Thanks a lot, > Spiros > > Τη Κυριακή, 26 Μαρτίου 2017 - 11:39:35 μ.μ. UTC+3, ο χρήστης Spiros C > έγραψε: >> >> I did a pull request: >> https://github.com/beetbox/beets/pull/2495#partial-pull-merging >> But it has a problem that I cant understand with Travis ci.Any help? >> >> Τη Κυριακή, 26 Μαρτίου 2017 - 8:49:10 μ.μ. UTC+3, ο χρήστης steve έγραψε: >>> >>> Sorry for the bad paste. >>> https://help.github.com/articles/creating-a-pull-request/ >>> >>> >>> >>> On Sun, Mar 26, 2017, at 10:48 AM, Steve Johnson wrote: >>> >>> Submit a pull request on GitHub. >>> >>> https://help.github.com/articles/creatin… >>> >>> >>> On Sun, Mar 26, 2017, at 03:50 AM, Spiros C wrote: >>> >>> Greetings, >>> I tryied to fix this issue: https://github.com/beetbox/beets/issues/2366 >>> and I think I made it. I forked beets and added my changes here: >>> https://github.com/SpirosChadoulos/beets/commit/2fbc7f0e70ed458708c8c5b5425d1f35ddf4ee9b >>> >>> . What should I do now so that my changes get accepted to the main beets >>> code as a pull request? >>> Thanks a lot, >>> Spiros >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "beets" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >>> >>> >>> > -- > You received this message because you are subscribed to the Google Groups > "beets" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > For more options, visit https://groups.google.com/d/optout. > > >
-- You received this message because you are subscribed to the Google Groups "beets" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
