Hi John,
Thanks for getting back to me with your findings. I really appreciate
it. I've gone through everything, made the changes that I could, and I have
some questions to some of your remarks.
> You are using the value from readdir() without prepending the path to the
> file name.
Unless I'm mistaken, I believe the full paths are being set in the
variables, before being used by opendir. Am I misunderstanding something?
> autoconfig.cgi:883: print "<font color=\"336666\">[dir] $dir/$file</font> -
> .htaccess installed<br>\n";
> The variable $file is not assigned a value.
I'm not seeing this. I thought it was set earlier in the security sub,
but maybe I've just been staring at it for too long.
> Surf.pm:65: $cookie =~ Encode($cookie);
> Surf.pm:66: $value =~ Encode($value);
> Did you really mean to use the return value from Encode() as a regular
> expression?
Unfortunately, I can't answer this, as I wasn't the one who wrote that
code and I don't understand cookies. If someone knows the answer to this, I'd
appreciate hearing it.
I also ran perl -c, as well as PerlCritic, on all the files and have
uploaded a "cleaned up" version (1.5.1) to our site. Here's a direct link:
http://www.surfshopcart.com/download-zip.php
> Antway, I found some mistakes in your code; to wit:
You were being kind. ;) Thank you again!
Can I reference your name as a contributor, or would you prefer to keep
your name off the project? Also, would you consider joining us?
Regards,
Frank
--
To unsubscribe, e-mail: beginners-unsubscr...@perl.org
For additional commands, e-mail: beginners-h...@perl.org
http://learn.perl.org/
