On Tuesday 31 Aug 2004 01:51, you wrote: > Gavin Henry wrote: > > > Hi all, > > > > > > This is my first real go at a perl script. Thoughts? > > Congrats on your first script. > > Suggestions: > > 1. Indent code inside blocks.
ok. > > 2. The way you're calling system() looks odd. You're using more than one > arg, which is a signal to bypass the shell. But your second arg looks like > it needs shell processing. Does this actually work? Yup, out of the cookbook. > > 3. Why not put the die() inside the else block? yeah. -- Just getting into the best language ever... Fancy a [EMAIL PROTECTED] Just ask!!! -- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] <http://learn.perl.org/> <http://learn.perl.org/first-response>
