Ok, I got it, indeed in OCL 1.1 there is following: The logical operators and (&&), or (||) operate on all scalar and vector built-in types except the built-in scalar and vector float types.
Thanks --Sun, Yi From: [email protected] [mailto:[email protected]] On Behalf Of Sun, Yi Sent: Wednesday, December 25, 2013 2:00 PM To: Song, Ruiling; '[email protected]' Cc: Zou, Nanhai; Jin, Gordon Subject: Re: [Beignet] [QA 2013/12/25 ] Status of Piglit test cases Hi Ruiling, After searching OCL spec 1.2, I got following (Chacpter 6.3): The logical operators and (&&), or (||) operate on all scalar and vector built-in types. The logical unary operator not (!) operates on all scalar and vector built-in types. Are you sure "Logical operators on float type is not permitted in OCL Spec"? Thanks --Sun, Yi From: [email protected]<mailto:[email protected]> [mailto:[email protected]] On Behalf Of Sun, Yi Sent: Wednesday, December 25, 2013 1:04 PM To: Song, Ruiling; '[email protected]' Cc: Zou, Nanhai; Jin, Gordon Subject: Re: [Beignet] [QA 2013/12/25 ] Status of Piglit test cases Ok, I'm going to look into it soon. Thanks --Sun, Yi From: Song, Ruiling Sent: Wednesday, December 25, 2013 12:46 PM To: Sun, Yi; '[email protected]' Cc: Zou, Nanhai; Jin, Gordon Subject: RE: [Beignet] [QA 2013/12/25 ] Status of Piglit test cases From: [email protected]<mailto:[email protected]> [mailto:[email protected]] On Behalf Of Sun, Yi Sent: Wednesday, December 25, 2013 11:44 AM To: '[email protected]' Cc: Zou, Nanhai; Jin, Gordon Subject: [Beignet] [QA 2013/12/25 ] Status of Piglit test cases summary: pass: 1517 fail: 2 crash: 0 skip: 11 warn: 0 dmesg-warn: 0 dmesg-fail: 0 total: 1530 Failed cases: Program/Execute/scalar-logical-float: fail [As discussed in the meeting, could you help send a patch to piglit to remove this case? Logical operators on float type is not permitted in OCL Spec] API/clCreateBuffer: fail Skipped cases: Program/Execute/Store/store-double-global: skip Program/Execute/Store/store-double2-local: skip Program/Execute/Store/store-double8-local: skip Program/Execute/Store/store-double4-global: skip Program/Execute/Store/store-double8-global: skip Program/Execute/Store/store-double16-global: skip Program/Execute/Store/store-double2-global: skip Program/Execute/Store/store-double-local: skip Program/Execute/Store/store-double4-local: skip Program/Execute/Store/store-double16-local: skip Program/Execute/program-tester-check-local-size-test-should-skip: skip (We're going to patch Piglit to make this case passed) commit 6e2d5ebf0a09590a3365302b088de20841ebd97e Author: Zhigang Gong <[email protected]<mailto:[email protected]>> Date: Wed Dec 18 07:19:05 2013 +0000 GBE: adjust instruction order for load/function call for vector. The previous implementation generates code as below: Thanks --Sun, Yi
_______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
