Hi Himanshu, Please see comments inline.
Hi Sami – Some more comments for your consideration (based on -09- version) – Many of the followings are either clarifications related or editorial. 1- Overall comment : the draft uses long sentences, short sentences are more favored (at least that is the feedback I used to get for my drafts). For example: --- original text -- Unlike EVPN where Ethernet Tag ID in EVPN routes are set to zero for Port-based, vlan-based, and vlan-bundle interface mode and it is set to non-zero Ethernet tag ID for vlan-aware bundle mode, in EVPN-VPWS, for all the four interface modes, Ethernet tag ID in the Ethernet A-D route MUST be set to a non-zero value in all the service interface types. ---- This could be written as – Ethernet tag ID in Ethernet A-D route MUST be set to a non-zero value irrespective of the service interface types. This is a deviation from what is expected for EVPN. In EVPN, Ethernet Tag ID in EVPN routes are set to zero for Port-based, vlan-based and vlan-bundle interface mode while non-zero Ethernet tag ID only for vlan-aware bundle mode. ---- [Sami] We are defining new interface types in other drafts, so we can’t say in the above text For all a service interface types for example, honestly I am not in favor to change the text. 2- In section 2.1 Original text --- If the VLAN is represented by different VIDs on different PEs. (note there should not be a period here) (e.g., a different VID per Ethernet segment per PE), then each PE needs to perform VID translation for frames destined to its Ethernet segment. Comment --- This particular paragraph is somewhat confusing. The confusing part is That text seems to indicate that multiple PEs connected to an ES may see same VLAN as different VID (which I believe is not true). [Sami] This is not what the text is indicating. For example, PE members PE1 and PE2 of same ESx, may see VID 100 for PE1 but 101 for PE2. [Sami] This is simply not possible, since the source of traffic on the ES is one for both PE1 and PE2. I believe what you are trying to convey is PEs on local ES and PEs on remote ES may have different VIDs. [Sami] I will add to the above text, on different PE (s) and different ES (es) instead of different PE (s) It can be clarified as – If the VLAN is represented by different VIDs on local PEs (connected to local ES) and remote PEs (connected to remote ES), then each PE needs to perform VID translation for frames destined to its Ethernet segment. --- 3- editorial Original text for page 8 – A remote PE SHOULD receive P=1 from only one Primary PE and a B-1 from only one Backup PE. Comment – B=1 [Sami] Sure will fix. 4- clarification original text – This allows an ingress PE to perform flow-based load-balancing of traffic flows to all of the PEs attached to that ES. Comment -- In multi-homed All-active configuration, this allows an ingress PE to perform Flow-based load-balancing of traffic flows to all the PEs attached to that ES. (I am assuming that in VPWS, single active multi-homing, there is load-balancing from remote to local multi-homed PEs – Right??) [Sami] Ok I will add that this is for all-active. Thanks, Sami
_______________________________________________ BESS mailing list [email protected] https://www.ietf.org/mailman/listinfo/bess
